Fix #2611: Deprecate ProvidedSponsorshipAssetsView#2929
Open
iampujan wants to merge 3 commits intopython:mainfrom
Open
Fix #2611: Deprecate ProvidedSponsorshipAssetsView#2929iampujan wants to merge 3 commits intopython:mainfrom
iampujan wants to merge 3 commits intopython:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Deprecates and removes the legacy ProvidedSponsorshipAssetsView endpoint/template now that “provided assets” are surfaced directly within SponsorshipDetailView (sponsorship_detail.html).
Changes:
- Removed
ProvidedSponsorshipAssetsViewand its URL route. - Deleted the legacy
sponsorship_assets_view.htmltemplate and removed the “View all assets” link from the sponsorship detail page. - Updated provided-asset
user_view_urlto point to the sponsorship detail page’s “Provided Assets” section.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/users/views.py | Removes the deprecated ProvidedSponsorshipAssetsView. |
| apps/users/urls.py | Removes the provided-assets/ route. |
| apps/users/templates/users/sponsorship_detail.html | Removes the link to the deleted provided-assets page. |
| apps/users/templates/users/sponsorship_assets_view.html | Deletes the deprecated template. |
| apps/sponsors/models/benefits.py | Updates user_view_url to deep-link to the provided-assets section on the sponsorship detail page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
ProvidedSponsorshipAssetsViewas its functionality is now wholly covered bySponsorshipDetailView. The old template and url have been removed.